freemyipod r88 - Code Review

Repository:	freemyipod
Revision:	< r87‎ \| r88 \| r89 >
Date:	02:10, 11 August 2010
Author:	theseven
Status:	new
Tags:
Comment:	Fix red
Modified paths:	/embios/trunk/target/ipodnano2g/clockgates.c (modified) (history) /embios/trunk/target/ipodnano2g/i2c.c (modified) (history) /embios/trunk/target/ipodnano2g/nand.c (modified) (history)

Diff [purge]

Index: embios/trunk/target/ipodnano2g/i2c.c
—	—	@@ -41,7 +41,7 @@
42	42	(2 << 0);
43	43
44	44	/* enable I2C clock */
45		~~- PWRCON &= ~(1 << 5);~~
	45	+ PWRCON(0) &= ~(1 << 5);
46	46
47	47	/* initial config */
48	48	IICADD = 0;
Index: embios/trunk/target/ipodnano2g/clockgates.c
—	—	@@ -22,7 +22,7 @@
23	23
24	24
25	25	#include "global.h"
26		~~-#include "s5l8720.h"~~
	26	+#include "s5l8701.h"
27	27
28	28
29	29	void clockgate_enable(int gate, bool enable)
Index: embios/trunk/target/ipodnano2g/nand.c
—	—	@@ -329,8 +329,8 @@
330	330	uint32_t i;
331	331	mutex_lock(&nand_mtx, TIMEOUT_BLOCK);
332	332	nand_last_activity_value = USEC_TIMER;
333		~~- PWRCONEXT &= ~0x40;~~
334		~~- PWRCON &= ~0x100000;~~
	333	+ PWRCON(1) &= ~0x40;
	334	+ PWRCON(0) &= ~0x100000;
335	335	PCON2 = 0x33333333;
336	336	PDAT2 = 0;
337	337	PCON3 = 0x11113333;
—	—	@@ -365,8 +365,8 @@
366	366	PDAT4 = 0;
367	367	PCON5 = (PCON5 & ~0xF) \| 1;
368	368	PUNK5 = 1;
369		~~- PWRCONEXT \|= 0x40;~~
370		~~- PWRCON \|= 0x100000;~~
	369	+ PWRCON(1) \|= 0x40;
	370	+ PWRCON(0) \|= 0x100000;
371	371	nand_powered = 0;
372	372	mutex_unlock(&nand_mtx);
373	373	}