freemyipod r876 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:< r875‎ | r876 | r877 >
Date:13:17, 27 July 2013
Author:theseven
Status:new
Tags:
Comment:
elf2emcoreapp: Revert r871/r872, fix BFD instead.
Modified paths:
  • /tools/elf2emcoreapp/elf2emcoreapp.c (modified) (history)

Diff [purge]

Index: tools/elf2emcoreapp/elf2emcoreapp.c
——@@ -772,7 +772,7 @@
773773 sym_reloc_size = bfd_get_reloc_size(q->howto);
774774
775775 #if !defined(TARGET_h8300) && !defined(TARGET_e1) && !defined(TARGET_bfin) && !defined(TARGET_m68k)
776 - if ((*p)->howto->type && sym_reloc_size != 4) {
 776+ if (sym_reloc_size != 4) {
777777 printf("ERROR: bad reloc type %d size=%d for symbol=%s\n",
778778 (*p)->howto->type, sym_reloc_size, sym_name);
779779 bad_relocs++;
——@@ -798,8 +798,6 @@
799799 #endif
800800
801801 #if defined(TARGET_arm)
802 - case 0:
803 - if (!sym_section->flags) break;
804802 case R_ARM_ABS32:
805803 relocation_needed = 1;
806804 sym_vma = bfd_section_vma(abs_bfd, sym_section);

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r871elf2emcoreapp: Ignore R_ARM_NONE relocation entriestheseven16:31, 24 July 2013
r872elf2emcoreapp: Attempt to guess relocation type in case of broken BFD librarytheseven11:42, 27 July 2013
Retrieved from "https://freemyipod.org/wiki/Special:Code/freemyipod/876"