freemyipod r829 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:r828‎ | r829 | r830 >
Date:20:02, 24 December 2011
Author:user890104
Status:new
Tags:
Comment:
emCOREFS: Make choosing a specific GCC version to build with possible, also explain that linking with GCC 4.5+ is broken for some reason
Modified paths:
  • /emcore/trunk/tools/emcorefs/Makefile (modified) (history)
  • /emcore/trunk/tools/emcorefs/README (modified) (history)

Diff [purge]

Index: emcore/trunk/tools/emcorefs/Makefile
@@ -1,4 +1,6 @@
 2+GCC ?= gcc
23 CFLAGS += -O2 -Wall -Wextra -Werror $(shell pkg-config --cflags --libs libusb-1.0 fuse)
 4+
35 SOURCES = util.c usb.c emcore.c cache.c fuse.c emcorefs.c
46 TARGET = build/emcorefs
57
@@ -8,10 +10,10 @@
911 @mkdir $@
1012
1113 $(TARGET): build
12 - gcc $(CFLAGS) -o $(TARGET) $(SOURCES)
 14+ $(GCC) $(CFLAGS) -o $(TARGET) $(SOURCES)
1315
1416 debug: build
15 - gcc $(CFLAGS) -DDEBUG -g -o $(TARGET) $(SOURCES)
 17+ $(GCC) $(CFLAGS) -DDEBUG -g -o $(TARGET) $(SOURCES)
1618
1719 test:
1820 @mkdir -p mountpoint
@@ -22,7 +24,7 @@
2325 $(TARGET) -d -s mountpoint/
2426
2527 testonly:
26 - gcc $(CFLAGS) -DTEST_ONLY -DDEBUG -g -o $(TARGET) $(SOURCES)
 28+ $(GCC) $(CFLAGS) -DTEST_ONLY -DDEBUG -g -o $(TARGET) $(SOURCES)
2729
2830 clean:
2931 @rm -rf build
Index: emcore/trunk/tools/emcorefs/README
@@ -13,10 +13,10 @@
1414 Building
1515 --------
1616 You need:
17 -1. GCC/Make (Xcode on OS X)
 17+1. GCC(<4.5) and GNU Make on Linux // Xcode on OS X
1818 2. pkg-config
1919 3. libusb >= 1.0
20 -4. libfuse >= 2.8 (or fuse4x on x64 OS X)
 20+4. libfuse >= 2.8 on Linux // fuse4x on x64 OS X
2121 5. all dependencies of the above
2222
2323 Compiling:
@@ -56,6 +56,9 @@
5757 * Most errors are not handled properly, EIO (Input/output error) is
5858 given in many cases where there's a more descriptive error
5959 message available. Will be fixed in the future.
 60+* Linking using gcc-4.5+ doesn't seem to work properly. You can set
 61+ the desired GCC version with the GCC Makefile viariable.
 62+ For example: GCC=gcc-4.4 make debug
6063
6164 Future plans
6265 ------------