freemyipod r8 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:< r7‎ | r8 | r9 >
Date:23:13, 29 July 2010
Author:theseven
Status:new
Tags:
Comment:
Some correctness fixes in the ipodnano2g LCD driver, no functional change
Modified paths:
  • /embios/trunk/target/ipodnano2g/lcd.S (modified) (history)

Diff [purge]

Index: embios/trunk/target/ipodnano2g/lcd.S
——@@ -107,29 +107,29 @@
108108
109109 displaylcd_sendlcd2c:
110110 ldr r4, [r12,#0x1c]
111 - ands r4, r4, #0x10
 111+ tst r4, #0x10
112112 bne displaylcd_sendlcd2c
113113 mov r4, r0,lsr#8
114114 str r4, [r12,#0x04]
115115 and r0, r0, #0xff
116116 displaylcd_sendlcdc:
117 - ldr r4, [r12,#0x1c]
118 - ands r4, r4, #0x10
 117+ ldrh r4, [r12,#0x1c]
 118+ tst r4, #0x10
119119 bne displaylcd_sendlcdc
120 - str r0, [r12,#0x04]
 120+ strh r0, [r12,#0x04]
121121 mov pc, lr
122122 displaylcd_sendlcd2d:
123 - ldr r4, [r12,#0x1c]
124 - ands r4, r4, #0x10
 123+ ldrh r4, [r12,#0x1c]
 124+ tst r4, #0x10
125125 bne displaylcd_sendlcd2d
126126 mov r4, r0,lsr#8
127 - str r4, [r12,#0x40]
 127+ strh r4, [r12,#0x40]
128128 and r0, r0, #0xff
129129 displaylcd_sendlcdd:
130 - ldr r4, [r12,#0x1c]
131 - ands r4, r4, #0x10
 130+ ldrh r4, [r12,#0x1c]
 131+ tst r4, #0x10
132132 bne displaylcd_sendlcdd
133 - str r0, [r12,#0x40]
 133+ strh r0, [r12,#0x40]
134134 mov pc, lr
135135
136136 displaylcd_detectlcd:
Retrieved from "https://freemyipod.org/wiki/Special:Code/freemyipod/8"