freemyipod r683 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:r682‎ | r683 | r684 >
Date:22:44, 30 March 2011
Author:theseven
Status:new
Tags:
Comment:
emCORE: Disable undervolting on iPod Classic. This needs more stability testing.
Modified paths:
  • /emcore/trunk/target/ipodnano3g/lcd.c (modified) (history)
  • /emcore/trunk/target/ipodnano3g/pmu.c (modified) (history)

Diff [purge]

Index: emcore/trunk/target/ipodnano3g/pmu.c
@@ -52,8 +52,8 @@
5353 void pmu_init()
5454 {
5555 mutex_init(&pmumutex);
56 - pmu_write(0x1e, 0x0f); // Vcore @ 1.000V
57 - pmu_write(0x22, 0x22); // Vmem @ 1.475V
 56+// pmu_write(0x1e, 0x0f); // Vcore @ 1.000V
 57+// pmu_write(0x22, 0x22); // Vmem @ 1.475V
5858 }
5959
6060 int pmu_read_adc(unsigned int adc)
Index: emcore/trunk/target/ipodnano3g/lcd.c
@@ -99,16 +99,16 @@
100100 // pmu_write(0x31, 0x0b); // Vlcd @ 2.000V
101101 // break;
102102 case 1:
103 - pmu_write(0x31, 0x0e); // Vlcd @ 2.300V
 103+// pmu_write(0x31, 0x0e); // Vlcd @ 2.300V
104104 break;
105105 case 2:
106 - pmu_write(0x31, 0x12); // Vlcd @ 2.700V
 106+// pmu_write(0x31, 0x12); // Vlcd @ 2.700V
107107 break;
108108 // case 3:
109109 // pmu_write(0x31, 0x0b); // Vlcd @ 2.000V
110110 // break;
111 - default:
112 - pmu_write(0x31, 0x0b); // Vlcd @ 2.000V
 111+// default:
 112+// pmu_write(0x31, 0x0b); // Vlcd @ 2.000V
113113 }
114114 }
115115
@@ -347,6 +347,7 @@
348348
349349 void lcd_shutdown()
350350 {
 351+ mutex_lock(&lcd_mutex, TIMEOUT_BLOCK);
351352 displaylcd_sync();
352353 uint32_t type = lcd_detect();
353354 if (type & 2)