freemyipod r40 - Code Review

Repository:	freemyipod
Revision:	< r39‎ \| r40 \| r41 >
Date:	08:32, 6 August 2010
Author:	cmwslw
Status:	new
Tags:
Comment:	Copied lcdconsole.c changes from r14. Fixes an annoying bug.
Modified paths:	/embios/branches/4g_compat/lcdconsole.c (modified) (history)

Diff [purge]

Index: embios/branches/4g_compat/lcdconsole.c
—	—	@@ -23,6 +23,7 @@
24	24
25	25	#include "global.h"
26	26	#include "lcdconsole.h"
	27	+#include "drawing.h"
27	28	#include "util.h"
28	29
29	30
—	—	@@ -49,11 +50,7 @@
50	51
51	52	void lcdconsole_putc(char string, int fgcolor, int bgcolor)
52	53	{
53		~~- if (string == '\r')~~
54		~~- {~~
55		~~- current_col = 0;~~
56		~~- return;~~
57		~~- }~~
	54	+ if (string == '\r') return;
58	55	current_col++;
59	56	if (string == '\n')
60	57	{
—	—	@@ -74,12 +71,13 @@
75	72	if (current_row >= LCDCONSOLE_ROWS)
76	73	{
77	74	int offset = current_row - LCDCONSOLE_ROWS + 1;
78		~~- memcpy(framebuf, &framebuf[ROWBYTES * offset], ROWBYTES * offset);~~
79		~~- memset(&framebuf[sizeof(framebuf) - ROWBYTES * offset],~~
	75	+ memcpy(&framebuf[LINEBYTES * OFFSETY], &framebuf[LINEBYTES * OFFSETY + ROWBYTES * offset],
	76	+ ROWBYTES * (LCDCONSOLE_ROWS - offset));
	77	+ memset(&framebuf[LINEBYTES * OFFSETY + ROWBYTES * (LCDCONSOLE_ROWS - offset)],
80	78	-1, ROWBYTES * offset);
	79	+ current_row = LCDCONSOLE_ROWS - 1;
81	80	}
82		~~- renderchar(&framebuf[OFFSETBYTES + ROWBYTES * current_row~~
83		~~- + COLBYTES * current_col],~~
	81	+ renderchar(&framebuf[OFFSETBYTES + ROWBYTES * current_row + COLBYTES * current_col],
84	82	fgcolor, bgcolor, string, LINEBYTES);
85	83	}
86	84

Revision	Commit summary	Author	Date
r14	Implement preemptive multitasking kernel	theseven	21:43, 31 July 2010