freemyipod r333 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:r332‎ | r333 | r334 >
Date:03:44, 13 December 2010
Author:theseven
Status:new
Tags:
Comment:
Installer for iPod Nano 2G: Fix a bunch of byteswapped colors
Modified paths:
  • /apps/installer-nano2g/flashfiles/iloader.conf (modified) (history)
  • /apps/installer-nano2g/main.c (modified) (history)

Diff [purge]

Index: apps/installer-nano2g/flashfiles/iloader.conf
@@ -18,11 +18,11 @@
1919 menu(nothememenu, 0, 0xffffffff, 0xfffffffe, 0xffffffff, 0xfffffffe, 0)
2020
2121 nothememenu:
22 - .menuentry(" Uninstall iLoader \0", 16, 56, 0x0000, 0xffff, 0xffff, 0x1f00, uninstall)
23 - .menuentry(" Enter disk mode \0", 16, 64, 0x0000, 0xffff, 0xffff, 0x1f00, diskmode)
24 - .menuentry(" Run UMSboot \0", 16, 72, 0x0000, 0xffff, 0xffff, 0x1f00, umsboot)
25 - .menuentry(" Quit iLoader \0", 16, 80, 0x0000, 0xffff, 0xffff, 0x1f00, quit)
26 - .menuentry(" Power off \0", 16, 88, 0x0000, 0xffff, 0xffff, 0x1f00, off)
 22+ .menuentry(" Uninstall iLoader \0", 16, 56, 0x0000, 0xffff, 0xffff, 0x001f, uninstall)
 23+ .menuentry(" Enter disk mode \0", 16, 64, 0x0000, 0xffff, 0xffff, 0x001f, diskmode)
 24+ .menuentry(" Run UMSboot \0", 16, 72, 0x0000, 0xffff, 0xffff, 0x001f, umsboot)
 25+ .menuentry(" Quit iLoader \0", 16, 80, 0x0000, 0xffff, 0xffff, 0x001f, quit)
 26+ .menuentry(" Power off \0", 16, 88, 0x0000, 0xffff, 0xffff, 0x001f, off)
2727 .word(0)
2828
2929 diskmode:
Index: apps/installer-nano2g/main.c
@@ -602,7 +602,7 @@
603603 renderbmp(&lcdbuffer[176 * 36], bmpbuffer, 176);
604604 displaylcd(0, 175, 0, 131, lcdbuffer, 0);
605605 free(bmpbuffer);
606 - progressbar_init(&progressbar, 15, 160, 50, 60, 0xce79, 0x18e3, 0x7bf9, 0, 100);
 606+ progressbar_init(&progressbar, 15, 160, 50, 60, 0x79ce, 0xe318, 0xf97b, 0, 100);
607607
608608 syscfgptr = malloc(0x1000);
609609 if (appleflash)
@@ -775,7 +775,7 @@
776776 renderbmp(&lcdbuffer[176 * 36], bmpbuffer, 176);
777777 displaylcd(0, 175, 0, 131, lcdbuffer, 0);
778778 free(bmpbuffer);
779 - progressbar_init(&progressbar, 15, 160, 50, 60, 0xce79, 0x18e3, 0x7bf9, 0, 100);
 779+ progressbar_init(&progressbar, 15, 160, 50, 60, 0x79ce, 0xe318, 0xf97b, 0, 100);
780780 if (fat32_resize_fulldisk(&progressbar))
781781 panic(PANIC_KILLTHREAD, "Data flash I/O error!");
782782 }
@@ -786,7 +786,7 @@
787787 bmpbuffer, &dummy);
788788 renderbmp(&lcdbuffer[176 * 36], bmpbuffer, 176);
789789 displaylcd(0, 175, 0, 131, lcdbuffer, 0);
790 - progressbar_init(&progressbar, 15, 160, 50, 60, 0xce79, 0x18e3, 0x7bf9, 0, 100);
 790+ progressbar_init(&progressbar, 15, 160, 50, 60, 0x79ce, 0xe318, 0xf97b, 0, 100);
791791 disk_mount(0);
792792 int updating = mkdir("/iLoader");
793793 int status;
@@ -800,7 +800,7 @@
801801 status = script[sp + 2] + script[sp + 3];
802802 sp += 4;
803803 }
804 - progressbar_init(&progressbar, 15, 160, 50, 60, 0xce79, 0x18e3, 0x7bf9, 0, status);
 804+ progressbar_init(&progressbar, 15, 160, 50, 60, 0x79ce, 0xe318, 0xf97b, 0, status);
805805 status = 0;
806806 while (script[sp])
807807 {
@@ -858,7 +858,7 @@
859859 ucl_decompress(bitmapdata[BMPIDX_FLASHING], bitmapsize[BMPIDX_FLASHING], bmpbuffer, &dummy);
860860 renderbmp(&lcdbuffer[176 * 36], bmpbuffer, 176);
861861 displaylcd(0, 175, 0, 131, lcdbuffer, 0);
862 - progressbar_init(&progressbar, 15, 160, 50, 60, 0xce79, 0x18e3, 0x7bf9, 0, 256);
 862+ progressbar_init(&progressbar, 15, 160, 50, 60, 0x79ce, 0xe318, 0xf97b, 0, 256);
863863 for (i = 0; i < 256; i++)
864864 {
865865 bootflash_writeraw(&norbuf[i << 12], i << 12, 1 << 12);

Follow-up revisions

RevisionCommit summaryAuthorDate
r414Installer for iPod Nano2G: Revert r333, those colors were already correct.theseven23:42, 7 January 2011