freemyipod r313 - Code Review

Repository:	freemyipod
Revision:	< r312‎ \| r313 \| r314 >
Date:	00:42, 3 December 2010
Author:	theseven
Status:	new
Tags:
Comment:	iLoader: Fix some yellow (implicit signedness casts)
Modified paths:	/apps/iloader/main.c (modified) (history)

Diff [purge]

Index: apps/iloader/main.c
—	—	@@ -167,11 +167,11 @@
168	168	{
169	169	if (bootflash_is_memmapped)
170	170	{
171		~~- if (!ucl_decompress(bootflash_getaddr("ildrcfg "), size, config, &size))~~
	171	+ if (!ucl_decompress(bootflash_getaddr("ildrcfg "), size, config, (uint32_t*)&size))
172	172	goto configfound;
173	173	}
174	174	else if (bootflash_read("ildrcfg ", backdrop, 0, size) == size)
175		~~- if (!ucl_decompress(backdrop, size, config, &size))~~
	175	+ if (!ucl_decompress(backdrop, size, config, (uint32_t*)&size))
176	176	goto configfound;
177	177	}
178	178	else if (bootflash_read("ildrcfg ", config, 0, size) == size)
—	—	@@ -216,7 +216,7 @@
217	217	if (bootflash_is_memmapped)
218	218	{
219	219	if (ucl_decompress(bootflash_getaddr(filename), size,
220		~~- (void*)config[pc + 1], &size))~~
	220	+ (void)config[pc + 1], (uint32_t)&size))
221	221	pc = errhandler;
222	222	else pc += 3;
223	223	}
—	—	@@ -223,7 +223,7 @@
224	224	else if (bootflash_read(filename, (void*)(0x09e00000 - size), 0, size) == size)
225	225	{
226	226	if (ucl_decompress((void*)(0x09e00000 - size), size,
227		~~- (void*)config[pc + 1], &size))~~
	227	+ (void)config[pc + 1], (uint32_t)&size))
228	228	pc = errhandler;
229	229	else pc += 3;
230	230	}
—	—	@@ -452,7 +452,8 @@
453	453	execfirmware((void*)config[pc + 1]);
454	454
455	455	case 0x14:
456		~~- if (ucl_decompress((void)config[pc + 1], size, (void)config[pc + 2], &size))~~
	456	+ if (ucl_decompress((void*)config[pc + 1], size,
	457	+ (void)config[pc + 2], (uint32_t)&size))
457	458	pc = errhandler;
458	459	else pc += 3;
459	460	break;