freemyipod r3 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:r2‎ | r3 | r4 >
Date:22:53, 27 July 2010
Author:theseven
Status:new
Tags:
Comment:
Fix a dependency generation bug and a mistyped filename in SOURCES
Modified paths:
  • /embios/trunk/Makefile (modified) (history)
  • /embios/trunk/SOURCES (modified) (history)

Diff [purge]

Index: embios/trunk/SOURCES
@@ -3,7 +3,7 @@
44 target/ipodnano2g/lcd.c
55 target/ipodnano2g/nand.c
66 target/ipodnano2g/storage.c
7 -target/ipodnano2g/i2c.c
 7+target/ipodnano2g/i2c.S
88 #endif
99
1010 init.c
Index: embios/trunk/Makefile
@@ -41,7 +41,7 @@
4242 @$(CC) -MM $(CFLAGS) -Itarget/$(1) -D TARGET=$(1) $$< > $$@.dep
4343 @mv -f $$@.dep $$@.dep.tmp
4444 @sed -e "s|.*:|$$@:|" < $$@.dep.tmp > $$@.dep
45 - @sed -e "s/.*://" -e "s/\\$$$$//" < $$@.dep.tmp | fmt -1 | sed -e "s/^ *//" -e "s/$$$$/:/" >> $$@.dep
 45+ @sed -e "s/.*://" -e "s/\\\\$$$$//" < $$@.dep.tmp | fmt -1 | sed -e "s/^ *//" -e "s/$$$$/:/" >> $$@.dep
4646 @rm -f $$@.dep.tmp
4747
4848 build/$(1)/%.o: %.S
@@ -54,7 +54,7 @@
5555 @$(CC) -MM $(CFLAGS) -Itarget/$(1) -D TARGET=$(1) $$< > $$@.dep
5656 @mv -f $$@.dep $$@.dep.tmp
5757 @sed -e "s|.*:|$$@:|" < $$@.dep.tmp > $$@.dep
58 - @sed -e "s/.*://" -e "s/\\$$$$//" < $$@.dep.tmp | fmt -1 | sed -e "s/^ *//" -e "s/$$$$/:/" >> $$@.dep
 58+ @sed -e "s/.*://" -e "s/\\\\$$$$//" < $$@.dep.tmp | fmt -1 | sed -e "s/^ *//" -e "s/$$$$/:/" >> $$@.dep
5959 @rm -f $$@.dep.tmp
6060 endef
6161