freemyipod r284 - Code Review

Repository:	freemyipod
Revision:	< r283‎ \| r284 \| r285 >
Date:	19:40, 27 November 2010
Author:	theseven
Status:	new
Tags:
Comment:	emBIOS: iPod Classic VBUS detection (no firewire for now, I don't have a cable for that)
Modified paths:	/embios/trunk/target/ipodnano2g/power.c (modified) (history) /embios/trunk/target/ipodnano3g/power.c (modified) (history)

Diff [purge]

Index: embios/trunk/target/ipodnano2g/power.c
—	—	@@ -50,7 +50,7 @@
51	51	{
52	52	pmu_init();
53	53	pmu_write(0x1e, 15); /* Vcore = 1.000V */
54		~~- pmu_ldo_set_voltage(2, 0x11); /* LCD = 2.600V */~~
	54	+ pmu_ldo_set_voltage(2, 0x11); /* LCD = 2.600V */
55	55	}
56	56
57	57	bool charging_state(void)
Index: embios/trunk/target/ipodnano3g/power.c
—	—	@@ -58,10 +58,10 @@
59	59
60	60	bool external_power_state(void)
61	61	{
62		~~- return false;~~
	62	+ return (PDAT(12) & 8) ? false : true;
63	63	}
64	64
65	65	bool vbus_state(void)
66	66	{
67		~~- return true;~~
	67	+ return (PDAT(12) & 8) ? false : true;
68	68	}