freemyipod r276 - Code Review

Repository:	freemyipod
Revision:	< r275‎ \| r276 \| r277 >
Date:	00:26, 23 November 2010
Author:	theseven
Status:	new
Tags:
Comment:	libembios: Fix readbootflash/writebootflash (args swapped around)
Modified paths:	/embios/trunk/tools/embios.py (modified) (history)

Diff [purge]

Index: embios/trunk/tools/embios.py
—	—	@@ -600,7 +600,8 @@
601	601	size = self._hexint(size)
602	602	self.logger.info("Dumping boot flash addresses "+self._hex(addr_flash)+" - "+
603	603	hex(addr_flash+size)+" to "+self._hex(addr_mem)+" - "+self._hex(addr_mem+size)+"\n")
604		~~- self.embios.bootflashread(addr_flash, addr_mem, size)~~
	604	+ self.embios.lib.dev.timeout = 5000
	605	+ self.embios.bootflashread(addr_mem, addr_flash, size)
605	606
606	607	@command
607	608	def writebootflash(self, addr_flash, addr_mem, size, force=False):
—	—	@@ -624,7 +625,8 @@
625	626	self.logger.info(".")
626	627	time.sleep(1)
627	628	self.logger.info("\n")
628		~~- self.embios.bootflashwrite(addr_flash, addr_mem, size)~~
	629	+ self.embios.lib.dev.timeout = 30000
	630	+ self.embios.bootflashwrite(addr_mem, addr_flash, size)
629	631
630	632	@command
631	633	def runfirmware(self, addr, filename):