freemyipod r219 - Code Review

Repository:	freemyipod
Revision:	< r218‎ \| r219 \| r220 >
Date:	16:54, 9 October 2010
Author:	theseven
Status:	new
Tags:
Comment:	Mask all interrupts in the interrupt controller (not just in the CPU) before executing firmware (fixes diagmode on nano2g)
Modified paths:	/embios/trunk/arm/contextswitch.S (modified) (history) /embios/trunk/interrupt.h (modified) (history) /embios/trunk/target/ipodnano2g/interrupt.c (modified) (history) /embios/trunk/target/ipodnano4g/interrupt.c (modified) (history)

Diff [purge]

Index: embios/trunk/target/ipodnano2g/interrupt.c
—	—	@@ -151,3 +151,8 @@
152	152	{
153	153	INTMSK = (1 << IRQ_TIMER) \| (1 << IRQ_DMA);
154	154	}
	155	+
	156	+void interrupt_shutdown(void)
	157	+{
	158	+ INTMSK = 0;
	159	+}
Index: embios/trunk/target/ipodnano4g/interrupt.c
—	—	@@ -177,3 +177,9 @@
178	178	{
179	179	VIC0INTENABLE = 1 << IRQ_TIMER;
180	180	}
	181	+
	182	+void interrupt_shutdown(void)
	183	+{
	184	+ VIC0INTENCLEAR = 0xffffffff;
	185	+ VIC1INTENCLEAR = 0xffffffff;
	186	+}
Index: embios/trunk/arm/contextswitch.S
—	—	@@ -149,6 +149,7 @@
150	150	.type execfirmware, %function
151	151	execfirmware:
152	152	str r0, [sp,#-4]!
	153	+ bl interrupt_shutdown
153	154	bl clean_dcache
154	155	ldr r1, [sp], #4
155	156	msr cpsr_c, #0xd3
Index: embios/trunk/interrupt.h
—	—	@@ -30,6 +30,7 @@
31	31
32	32	void irqhandler(void) ICODE_ATTR;
33	33	void interrupt_init(void) INITCODE_ATTR;
	34	+void interrupt_shutdown(void);
34	35	void interrupt_enable(int irq, bool state);
35	36	void interrupt_set_handler(int irq, void* handler);
36	37	void int_timer_set_handler(int timer, void* handler);