freemyipod r131 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:r130‎ | r131 | r132 >
Date:00:43, 14 August 2010
Author:theseven
Status:new
Tags:
Comment:
Remove low level NAND access APIs from the syscall interface. This is not something we want, now that nandfsck is integrated into the core
Modified paths:
  • /embios/trunk/export/syscallapi.h (modified) (history)
  • /embios/trunk/export/syscallwrappers.h (modified) (history)
  • /embios/trunk/nand.h (deleted) (history)
  • /embios/trunk/syscallapi.c (modified) (history)

Diff [purge]

Index: embios/trunk/nand.h
@@ -1,47 +0,0 @@
2 -//
3 -//
4 -// Copyright 2010 TheSeven
5 -//
6 -//
7 -// This file is part of emBIOS.
8 -//
9 -// emBIOS is free software: you can redistribute it and/or
10 -// modify it under the terms of the GNU General Public License as
11 -// published by the Free Software Foundation, either version 2 of the
12 -// License, or (at your option) any later version.
13 -//
14 -// emBIOS is distributed in the hope that it will be useful,
15 -// but WITHOUT ANY WARRANTY; without even the implied warranty of
16 -// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
17 -// See the GNU General Public License for more details.
18 -//
19 -// You should have received a copy of the GNU General Public License along
20 -// with emBIOS. If not, see <http://www.gnu.org/licenses/>.
21 -//
22 -//
23 -
24 -
25 -#ifndef __NAND_H__
26 -#define __NAND_H__
27 -
28 -#include "global.h"
29 -
30 -
31 -uint32_t nand_read_page(uint32_t bank, uint32_t page, void* databuffer,
32 - void* sparebuffer, uint32_t doecc,
33 - uint32_t checkempty);
34 -uint32_t nand_write_page(uint32_t bank, uint32_t page, void* databuffer,
35 - void* sparebuffer, uint32_t doecc);
36 -uint32_t nand_block_erase(uint32_t bank, uint32_t page);
37 -
38 -uint32_t nand_read_page_fast(uint32_t page, void* databuffer,
39 - void* sparebuffer, uint32_t doecc,
40 - uint32_t checkempty);
41 -uint32_t nand_write_page_start(uint32_t bank, uint32_t page, void* databuffer,
42 - void* sparebuffer, uint32_t doecc);
43 -uint32_t nand_write_page_collect(uint32_t bank);
44 -
45 -const struct nand_device_info_type* nand_get_device_type(uint32_t bank);
46 -
47 -
48 -#endif
Index: embios/trunk/export/syscallwrappers.h
@@ -127,13 +127,6 @@
128128 #define clean_dcache(args...) __embios_syscall->clean_dcache(args)
129129 #define invalidate_dcache(args...) __embios_syscall->invalidate_dcache(args)
130130 #define invalidate_icache(args...) __embios_syscall->invalidate_icache(args)
131 -#define nand_read_page(args...) __embios_syscall->nand_read_page(args)
132 -#define nand_block_erase(args...) __embios_syscall->nand_block_erase(args)
133 -#define nand_read_page_fast(args...) __embios_syscall->nand_read_page_fast(args)
134 -#define nand_write_page(args...) __embios_syscall->nand_write_page(args)
135 -#define nand_write_page_start(args...) __embios_syscall->nand_write_page_start(args)
136 -#define nand_write_page_collect(args...) __embios_syscall->nand_write_page_collect(args)
137 -#define nand_get_device_type(args...) __embios_syscall->nand_get_device_type(args)
138131 #define power_off(args...) __embios_syscall->power_off(args)
139132 #define charging_state(args...) __embios_syscall->charging_state(args)
140133 #define atoi(args...) __embios_syscall->atoi(args)
Index: embios/trunk/export/syscallapi.h
@@ -42,7 +42,6 @@
4343 #include "../interrupt.h"
4444 #include "../lcd.h"
4545 #include "../mmu.h"
46 -#include "../nand.h"
4746 #include "../power.h"
4847 #include "../execimage.h"
4948 #include "../backlight.h"
@@ -167,13 +166,6 @@
168167 typeof(clean_dcache) *clean_dcache;
169168 typeof(invalidate_dcache) *invalidate_dcache;
170169 typeof(invalidate_icache) *invalidate_icache;
171 - typeof(nand_read_page) *nand_read_page;
172 - typeof(nand_block_erase) *nand_block_erase;
173 - typeof(nand_read_page_fast) *nand_read_page_fast;
174 - typeof(nand_write_page) *nand_write_page;
175 - typeof(nand_write_page_start) *nand_write_page_start;
176 - typeof(nand_write_page_collect) *nand_write_page_collect;
177 - typeof(nand_get_device_type) *nand_get_device_type;
178170 typeof(power_off) *power_off;
179171 typeof(charging_state) *charging_state;
180172 typeof(atoi) *atoi;
Index: embios/trunk/syscallapi.c
@@ -170,15 +170,6 @@
171171 .bootflash_writeraw = bootflash_writeraw,
172172 .bootflash_getrawaddr = bootflash_getrawaddr,
173173 #endif
174 -#ifdef HAVE_NAND
175 - .nand_read_page = nand_read_page,
176 - .nand_block_erase = nand_block_erase,
177 - .nand_read_page_fast = nand_read_page_fast,
178 - .nand_write_page = nand_write_page,
179 - .nand_write_page_start = nand_write_page_start,
180 - .nand_write_page_collect = nand_write_page_collect,
181 - .nand_get_device_type = nand_get_device_type,
182 -#endif
183174 #ifdef HAVE_BUTTON
184175 .button_register_handler = button_register_handler,
185176 .button_unregister_handler = button_unregister_handler,