freemyipod r956 - Code Review

Repository:	freemyipod
Revision:	< r955‎ \| r956 \| r957 >
Date:	19:14, 16 June 2014
Author:	theseven
Status:	new
Tags:
Comment:	installer-ipodclassic: Revert r955. This was caused by using broken UMSboot builds.
Modified paths:	/apps/installer-ipodclassic/main.c (modified) (history)

Diff [purge]

Index: apps/installer-ipodclassic/main.c
—	—	@@ -95,9 +95,7 @@
96	96	for (i = 0; i < 16; i++) SHA1DATAIN[i] = tmp32[i];
97	97	}
98	98	else for (i = 0; i < 16; i++) SHA1DATAIN[i] = *databuf++;
99		~~- clean_dcache(); // Not sure why we need this, but apparently we do...~~
100	99	SHA1CONFIG \|= 2;
101		~~- invalidate_dcache(); // Not sure why we need this, but apparently we do...~~
102	100	while (SHA1CONFIG & 1) sleep(0);
103	101	SHA1CONFIG \|= 8;
104	102	}
—	—	@@ -231,19 +229,20 @@
232	230	if (flags & 8)
233	231	{
234	232	offs = 0x800;
235		~~- size = ((size + 0xf) & ~0xf);~~
	233	+ size = ((size + 0xf) & ~0xf) + offs;
236	234	}
237	235	if (flags & 1)
238	236	{
239		~~- endptr -= ((offs + size + 0xfff) & ~0xfff);~~
	237	+ endptr -= ((size + 0xfff) & ~0xfff);
	238	+ memcpy(&norbuf[endptr + offs], data, size);
240	239	file = endptr;
241	240	}
242	241	else
243	242	{
	243	+ memcpy(&norbuf[beginptr + offs], data, size);
244	244	file = beginptr;
245		~~- beginptr += ((offs + size + 0xfff) & ~0xfff);~~
	245	+ beginptr += ((size + 0xfff) & ~0xfff);
246	246	}
247		~~- memcpy(&norbuf[file + offs], data, size);~~
248	247	if (!(flags & 4))
249	248	{
250	249	if (dirptr >= 0x2000)
—	—	@@ -256,6 +255,7 @@
257	256	}
258	257	if (flags & 8)
259	258	{
	259	+ size -= offs;
260	260	memset(&norbuf[file], 0, 0x800);
261	261	memcpy(&norbuf[file], "87021.0\x01", 8);
262	262	((uint32_t)&norbuf[file + 0xc]) = size;

Revision	Commit summary	Author	Date
r955	installer-ipodclassic: Avoid SHA1 trouble for now. We should figure out the r...	theseven	18:30, 16 June 2014