freemyipod r890 - Code Review

Repository:	freemyipod
Revision:	< r889‎ \| r890 \| r891 >
Date:	14:27, 4 August 2013
Author:	theseven
Status:	new
Tags:
Comment:	UMSboot: Fix some more USB bugs
Modified paths:	/umsboot/src/core/synopsysotg/synopsysotg.c (modified) (history) /umsboot/src/protocol/usb/usb.c (modified) (history)

Diff [purge]

Index: umsboot/src/protocol/usb/usb.c
—	—	@@ -34,6 +34,12 @@
35	35	// Expect zero-length ACK if we are about to actually send data, otherwise expect SETUP.
36	36	if (last) usb_ep0_start_rx(data, !!len, usb_ep0_rx_callback);
37	37
	38	+ if (((uint32_t)buf) & (CACHEALIGN_SIZE - 1))
	39	+ {
	40	+ memcpy(data->buffer->raw, buf, len);
	41	+ buf = data->buffer->raw;
	42	+ }
	43	+
38	44	data->state->ep0_tx_callback = callback;
39	45	data->driver->ep0_start_tx(data, buf, len);
40	46	}
—	—	@@ -44,7 +50,7 @@
45	51	int len = MIN(64, data->state->ep0_tx_len);
46	52	data->state->ep0_tx_ptr += 64;
47	53	data->state->ep0_tx_len -= len;
48		~~- usb_ep0_start_tx(data, data->state->ep0_tx_ptr, len, !!data->state->ep0_tx_len, usb_ep0_tx_callback);~~
	54	+ usb_ep0_start_tx(data, data->state->ep0_tx_ptr, len, !data->state->ep0_tx_len, usb_ep0_tx_callback);
49	55	return true;
50	56	}
51	57
Index: umsboot/src/core/synopsysotg/synopsysotg.c
—	—	@@ -312,7 +312,7 @@
313	313	synopsysotg_ep0_init(instance);
314	314	}
315	315
316		~~- if (gintsts.b.rxstsqlvl)~~
	316	+ if (gintsts.b.rxstsqlvl && !data->use_dma)
317	317	{
318	318	// Device to memory part of the "software DMA" implementation, used to receive data if use_dma == 0.
319	319	// Handle one packet at a time, the IRQ will re-trigger if there's something left.