freemyipod r802 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:r801‎ | r802 | r803 >
Date:18:42, 19 November 2011
Author:theseven
Status:new
Tags:
Comment:
libemcore.py: Revert accidentally committed change
Modified paths:
  • /emcore/trunk/tools/libemcore.py (modified) (history)

Diff [purge]

Index: emcore/trunk/tools/libemcore.py
@@ -693,9 +693,8 @@
694694 self.logger.debug("Reading %d sectors from disk at volume %d, sector %d to memory at 0x%X\n" % (count, volume, sector, addr))
695695 result = self.lib.monitorcommand(struct.pack("<IIQIIII", 28, volume, sector, count, addr, 0, 0), "III", ("rc", None, None))
696696 self.logger.debug("Read sectors, result: 0x%X\n" % result.rc)
697 - self.logger.info(".");
698 -# if result.rc > 0x80000000:
699 -# raise DeviceError("storage_read_sectors_md(volume=%d, sector=%d, count=%d, addr=0x%08X) failed with RC 0x%08X" % (volume, sector, count, addr, result.rc))
 697+ if result.rc > 0x80000000:
 698+ raise DeviceError("storage_read_sectors_md(volume=%d, sector=%d, count=%d, addr=0x%08X) failed with RC 0x%08X" % (volume, sector, count, addr, result.rc))
700699
701700 @command(timeout = 50000)
702701 def storage_write_sectors_md(self, volume, sector, count, addr):
@@ -703,9 +702,8 @@
704703 self.logger.debug("Writing %d sectors from memory at 0x%X to disk at volume %d, sector %d\n" % (count, addr, volume, sector))
705704 result = self.lib.monitorcommand(struct.pack("<IIQIIII", 29, volume, sector, count, addr, 0, 0), "III", ("rc", None, None))
706705 self.logger.debug("Wrote sectors, result: 0x%X\n" % result.rc)
707 - self.logger.info(".");
708 -# if result.rc > 0x80000000:
709 -# raise DeviceError("storage_write_sectors_md(volume=%d, sector=%d, count=%d, addr=0x%08X) failed with RC 0x%08X" % (volume, sector, count, addr, result.rc))
 706+ if result.rc > 0x80000000:
 707+ raise DeviceError("storage_write_sectors_md(volume=%d, sector=%d, count=%d, addr=0x%08X) failed with RC 0x%08X" % (volume, sector, count, addr, result.rc))
710708
711709 @command(timeout = 30000)
712710 def fat_enable_flushing(self, state):