freemyipod r786 - Code Review

Repository:	freemyipod
Revision:	< r785‎ \| r786 \| r787 >
Date:	14:58, 18 November 2011
Author:	user890104
Status:	new
Tags:
Comment:	emCOREFS: fix a couple more memleaks (thanks to cppcheck), also a x64 int formatting issue.
Modified paths:	/emcore/trunk/tools/emcorefs/emcore.c (modified) (history) /emcore/trunk/tools/emcorefs/usb.c (modified) (history)

Diff [purge]

Index: emcore/trunk/tools/emcorefs/usb.c
—	—	@@ -82,7 +82,7 @@
83	83	}
84	84
85	85	#ifdef DEBUG
86		~~- fprintf(stderr, "Found %d USB devices!\n", devs_cnt);~~
	86	+ fprintf(stderr, "Found %ld USB devices!\n", devs_cnt);
87	87	#endif
88	88	for (i = 0; i < devs_cnt; ++i)
89	89	{
Index: emcore/trunk/tools/emcorefs/emcore.c
—	—	@@ -225,11 +225,15 @@
226	226
227	227	if (EMCORE_SUCCESS != res)
228	228	{
	229	+ free(in);
	230	+
229	231	return res;
230	232	}
231	233
232	234	memcpy(data, in + EMCORE_HEADER_SIZE, size);
233	235
	236	+ free(in);
	237	+
234	238	return EMCORE_SUCCESS;
235	239	}
236	240
—	—	@@ -332,11 +336,15 @@
333	337
334	338	if (EMCORE_SUCCESS != res)
335	339	{
	340	+ free(in);
	341	+
336	342	return res;
337	343	}
338	344
339	345	memcpy(data, in + 16, size);
340	346
	347	+ free(in);
	348	+
341	349	return EMCORE_SUCCESS;
342	350	}
343	351