freemyipod r777 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:< r776‎ | r777 | r778 >
Date:21:27, 24 October 2011
Author:user890104
Status:new
Tags:
Comment:
bootmenu-ipodnano2g: swap Disk mode and Console
bootmenu-ipodnano2g, bootmenu-ipodclassic: change/resize all icons to square
Modified paths:
  • /apps/bootmenu-ipodclassic/images/icons.png (modified) (history)
  • /apps/bootmenu-ipodclassic/images/icons.psd (modified) (history)
  • /apps/bootmenu-ipodclassic/main.c (modified) (history)
  • /apps/bootmenu-ipodnano2g/images/icons.png (modified) (history)
  • /apps/bootmenu-ipodnano2g/images/icons.psd (modified) (history)
  • /apps/bootmenu-ipodnano2g/main.c (modified) (history)

Diff [purge]

Index: apps/bootmenu-ipodclassic/images/icons.psd
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: apps/bootmenu-ipodclassic/images/icons.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: apps/bootmenu-ipodclassic/main.c
——@@ -377,10 +377,10 @@
378378
379379 struct chooser_renderer_iconflow_itemdata mainchooser_rparams_powerdown =
380380 {
381 - .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 56)),
382 - LIBUI_POINT(80, 79)),
383 - .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 56)),
384 - LIBUI_POINT(80, 79)),
 381+ .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 0)),
 382+ LIBUI_POINT(80, 80)),
 383+ .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 0)),
 384+ LIBUI_POINT(80, 80)),
385385 .text = "Power off",
386386 .text_color = 0xffffcccc,
387387 };
——@@ -393,10 +393,10 @@
394394
395395 struct chooser_renderer_iconflow_itemdata mainchooser_rparams_rockbox =
396396 {
397 - .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 0)),
398 - LIBUI_POINT(80, 25)),
399 - .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 0)),
400 - LIBUI_POINT(80, 25)),
 397+ .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 80)),
 398+ LIBUI_POINT(80, 80)),
 399+ .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 80)),
 400+ LIBUI_POINT(80, 80)),
401401 .text = "Rockbox",
402402 .text_color = 0xffffcccc,
403403 };
——@@ -429,10 +429,10 @@
430430
431431 struct chooser_renderer_iconflow_itemdata mainchooser_rparams_console =
432432 {
433 - .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 25)),
434 - LIBUI_POINT(80, 31)),
435 - .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 25)),
436 - LIBUI_POINT(80, 31)),
 433+ .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 160)),
 434+ LIBUI_POINT(80, 80)),
 435+ .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 160)),
 436+ LIBUI_POINT(80, 80)),
437437 .text = "emCORE console",
438438 .text_color = 0xffffcccc,
439439 };
——@@ -439,10 +439,10 @@
440440
441441 struct chooser_renderer_iconflow_itemdata mainchooser_rparams_toolchooser =
442442 {
443 - .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 136)),
444 - LIBUI_POINT(80, 84)),
445 - .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 136)),
446 - LIBUI_POINT(80, 84)),
 443+ .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 240)),
 444+ LIBUI_POINT(80, 80)),
 445+ .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 80), LIBUI_POINT(0, 240)),
 446+ LIBUI_POINT(80, 80)),
447447 .text = "Tools",
448448 .text_color = 0xffffcccc,
449449 };
Index: apps/bootmenu-ipodnano2g/images/icons.psd
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: apps/bootmenu-ipodnano2g/images/icons.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: apps/bootmenu-ipodnano2g/main.c
——@@ -449,9 +449,9 @@
450450
451451 struct chooser_renderer_iconflow_itemdata mainchooser_rparams_powerdown =
452452 {
453 - .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 31)),
 453+ .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 0)),
454454 LIBUI_POINT(44, 44)),
455 - .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 31)),
 455+ .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 0)),
456456 LIBUI_POINT(44, 44)),
457457 .text = "Power off",
458458 .text_color = 0xffffcccc,
——@@ -465,10 +465,10 @@
466466
467467 struct chooser_renderer_iconflow_itemdata mainchooser_rparams_crapple =
468468 {
469 - .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 123)),
470 - LIBUI_POINT(44, 43)),
471 - .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 123)),
472 - LIBUI_POINT(44, 43)),
 469+ .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 44)),
 470+ LIBUI_POINT(44, 44)),
 471+ .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 44)),
 472+ LIBUI_POINT(44, 44)),
473473 .text = "Original firmware",
474474 .text_color = 0xffffcccc,
475475 };
——@@ -494,10 +494,10 @@
495495
496496 struct chooser_renderer_iconflow_itemdata mainchooser_rparams_rockbox =
497497 {
498 - .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 0)),
499 - LIBUI_POINT(44, 14)),
500 - .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 0)),
501 - LIBUI_POINT(44, 14)),
 498+ .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 88)),
 499+ LIBUI_POINT(44, 44)),
 500+ .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 88)),
 501+ LIBUI_POINT(44, 44)),
502502 .text = "Rockbox",
503503 .text_color = 0xffffcccc,
504504 };
——@@ -528,22 +528,12 @@
529529 }
530530 }
531531
532 -struct chooser_renderer_iconflow_itemdata mainchooser_rparams_console =
533 -{
534 - .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 14)),
535 - LIBUI_POINT(44, 17)),
536 - .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 14)),
537 - LIBUI_POINT(44, 17)),
538 - .text = "emCORE console",
539 - .text_color = 0xffffcccc,
540 -};
541 -
542532 struct chooser_renderer_iconflow_itemdata mainchooser_rparams_diskmode =
543533 {
544 - .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 166)),
545 - LIBUI_POINT(44, 31)),
546 - .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 166)),
547 - LIBUI_POINT(44, 31)),
 534+ .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 132)),
 535+ LIBUI_POINT(44, 44)),
 536+ .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 132)),
 537+ LIBUI_POINT(44, 44)),
548538 .text = "Disk mode",
549539 .text_color = 0xffffcccc,
550540 };
——@@ -558,12 +548,22 @@
559549 }
560550 }
561551
 552+struct chooser_renderer_iconflow_itemdata mainchooser_rparams_console =
 553+{
 554+ .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 176)),
 555+ LIBUI_POINT(44, 44)),
 556+ .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 176)),
 557+ LIBUI_POINT(44, 44)),
 558+ .text = "emCORE console",
 559+ .text_color = 0xffffcccc,
 560+};
 561+
562562 struct chooser_renderer_iconflow_itemdata mainchooser_rparams_toolchooser =
563563 {
564 - .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 75)),
565 - LIBUI_POINT(44, 47)),
566 - .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 75)),
567 - LIBUI_POINT(44, 47)),
 564+ .icon = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 220)),
 565+ LIBUI_POINT(44, 44)),
 566+ .icon_selected = LIBUI_SURFACE(LIBUI_LOCATION(LIBUI_BUFFER(NULL, 44), LIBUI_POINT(0, 220)),
 567+ LIBUI_POINT(44, 44)),
568568 .text = "Tools",
569569 .text_color = 0xffffcccc,
570570 };
——@@ -650,14 +650,14 @@
651651 .renderparams = &mainchooser_rparams_rockbox
652652 },
653653 {
654 - .user = NULL,
 654+ .user = run_diskmode,
655655 .actionparams = NULL,
656 - .renderparams = &mainchooser_rparams_console
 656+ .renderparams = &mainchooser_rparams_diskmode
657657 },
658658 {
659 - .user = run_diskmode,
 659+ .user = NULL,
660660 .actionparams = NULL,
661 - .renderparams = &mainchooser_rparams_diskmode
 661+ .renderparams = &mainchooser_rparams_console
662662 },
663663 {
664664 .user = run_toolchooser,

Image changes

Index: /apps/bootmenu-ipodclassic/images/icons.png
replacedmodified
Index: /apps/bootmenu-ipodnano2g/images/icons.png
replacedmodified
Retrieved from "https://freemyipod.org/wiki/Special:Code/freemyipod/777"