freemyipod r63 - Code Review

Repository:	freemyipod
Revision:	< r62‎ \| r63 \| r64 >
Date:	05:59, 9 August 2010
Author:	cmwslw
Status:	new
Tags:
Comment:	Fixed the cprintf() bug where characters are printed one at a time.
Modified paths:	/embios/branches/4g_compat/console.c (modified) (history) /embios/branches/4g_compat/lcdconsole.c (modified) (history)

Diff [purge]

Index: embios/branches/4g_compat/console.c
—	—	@@ -41,7 +41,7 @@
42	42	static int cprfunc(void* ptr, unsigned char letter)
43	43	{
44	44	struct for_cprintf* pr = (struct for_cprintf*)ptr;
45		~~- cputc(pr->consoles, letter);~~
	45	+ cputc_noblit(pr->consoles, letter);
46	46	pr->bytes++;
47	47	return true;
48	48	}
—	—	@@ -57,6 +57,8 @@
58	58	va_start(ap, fmt);
59	59	format(cprfunc, &pr, fmt, ap);
60	60	va_end(ap);
	61	+
	62	+ lcdconsole_update();
61	63
62	64	return pr.bytes;
63	65	}
—	—	@@ -69,6 +71,8 @@
70	72	pr.bytes = 0;
71	73
72	74	format(cprfunc, &pr, fmt, ap);
	75	+
	76	+ lcdconsole_update();
73	77
74	78	return pr.bytes;
75	79	}
—	—	@@ -78,11 +82,21 @@
79	83	if (consoles & 1) lcdconsole_putc(string, 0, -1);
80	84	}
81	85
	86	+void cputc_noblit(unsigned int consoles, char string)
	87	+{
	88	+ if (consoles & 1) lcdconsole_putc_noblit(string, 0, -1);
	89	+}
	90	+
82	91	void cputs(unsigned int consoles, const char* string)
83	92	{
84	93	if (consoles & 1) lcdconsole_puts(string, 0, -1);
85	94	}
86	95
	96	+void cputs_noblit(unsigned int consoles, const char* string)
	97	+{
	98	+ if (consoles & 1) lcdconsole_puts_noblit(string, 0, -1);
	99	+}
	100	+
87	101	void cflush(unsigned int consoles)
88	102	{
89	103	if (consoles & 1) lcdconsole_update();
Index: embios/branches/4g_compat/lcdconsole.c
—	—	@@ -50,7 +50,11 @@
51	51
52	52	void lcdconsole_putc_noblit(char string, int fgcolor, int bgcolor)
53	53	{
54		~~- if (string == '\r') return;~~
	54	+ if (string == '\r')
	55	+ {
	56	+ current_col = 0;
	57	+ return;
	58	+ }
55	59	current_col++;
56	60	if (string == '\n')
57	61	{