freemyipod r598 - Code Review

Repository:	freemyipod
Revision:	< r597‎ \| r598 \| r599 >
Date:	20:42, 12 February 2011
Author:	theseven
Status:	new
Tags:
Comment:	emCORE: Rework yield vs. sleep usage a bit
Modified paths:	/emcore/trunk/target/ipodnano2g/hwkeyaes.c (modified) (history) /emcore/trunk/target/ipodnano2g/pmu.c (modified) (history) /emcore/trunk/target/ipodnano3g/hwkeyaes.c (modified) (history) /emcore/trunk/target/ipodnano3g/pmu.c (modified) (history)

Diff [purge]

Index: emcore/trunk/target/ipodnano2g/pmu.c
—	—	@@ -61,7 +61,7 @@
62	62	pmu_write(0x54, 5 \| (adc << 4));
63	63	while ((data & 0x80) == 0)
64	64	{
65		~~- yield();~~
	65	+ sleep(1000);
66	66	data = pmu_read(0x57);
67	67	}
68	68	int value = (pmu_read(0x55) << 2) \| (data & 3);
Index: emcore/trunk/target/ipodnano2g/hwkeyaes.c
—	—	@@ -62,7 +62,7 @@
63	63	AESSTATUS = 6;
64	64	AESGO = go;
65	65	go = 3;
66		~~- while ((AESSTATUS & 6) == 0) yield();~~
	66	+ while ((AESSTATUS & 6) == 0);
67	67	invalidate_dcache();
68	68	if (direction == HWKEYAES_DECRYPT)
69	69	{
Index: emcore/trunk/target/ipodnano3g/pmu.c
—	—	@@ -63,7 +63,7 @@
64	64	pmu_write(0x54, 5 \| (adc << 4));
65	65	while ((data & 0x80) == 0)
66	66	{
67		~~- yield();~~
	67	+ sleep(1000);
68	68	data = pmu_read(0x57);
69	69	}
70	70	int value = (pmu_read(0x55) << 2) \| (data & 3);
Index: emcore/trunk/target/ipodnano3g/hwkeyaes.c
—	—	@@ -54,7 +54,7 @@
55	55	clean_dcache();
56	56	AESGO = 1;
57	57	invalidate_dcache();
58		~~- while (!(AESSTATUS & 0xf)) sleep(100);~~
	58	+ while (!(AESSTATUS & 0xf)) sleep(MIN(10000, size >> 4));
59	59	clockgate_enable(10, false);
60	60	mutex_unlock(&hwkeyaes_mutex);
61	61	}