freemyipod r59 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:< r58‎ | r59 | r60 >
Date:23:25, 8 August 2010
Author:theseven
Status:new
Tags:
Comment:
Hopefully get rid of some warnings by rearranging some includes
Modified paths:
  • /embios/trunk/console.c (modified) (history)
  • /embios/trunk/dir.c (modified) (history)
  • /embios/trunk/disk.c (modified) (history)
  • /embios/trunk/fat.c (modified) (history)
  • /embios/trunk/file.h (modified) (history)
  • /embios/trunk/global.h (modified) (history)
  • /embios/trunk/snprintf.c (modified) (history)

Diff [purge]

Index: embios/trunk/console.c
——@@ -27,9 +27,7 @@
2828 #include "usb/dbgconsole.h"
2929 #include "format.h"
3030 #include "thread.h"
31 -#include <stdio.h>
3231 #include <stdarg.h>
33 -#include <stdbool.h>
3432 #include <limits.h>
3533
3634
Index: embios/trunk/snprintf.c
——@@ -27,9 +27,7 @@
2828 */
2929
3030 #include "global.h"
31 -#include <stdio.h>
3231 #include <stdarg.h>
33 -#include <stdbool.h>
3432 #include <limits.h>
3533 #include "format.h"
3634
Index: embios/trunk/disk.c
——@@ -20,7 +20,6 @@
2121 ****************************************************************************/
2222 #include "global.h"
2323 #include "thread.h"
24 -#include <stdio.h>
2524 #include "storage.h"
2625 #include "debug.h"
2726 #include "fat.h"
Index: embios/trunk/global.h
——@@ -27,6 +27,8 @@
2828 #ifndef ASM_FILE
2929 #include <stdint.h>
3030 #include <stddef.h>
 31+#include <stdbool.h>
 32+#include <stdio.h>
3133 #endif
3234
3335 #include "build/version.h"
——@@ -41,10 +43,6 @@
4244 #define INITBSS_ATTR __attribute__((section(".initbss")))
4345 #define STACK_ATTR __attribute__((section(".stack")))
4446
45 -#define bool int
46 -#define true 1
47 -#define false 0
48 -
4947 #include "configmagic.h"
5048 #include "debug.h"
5149
Index: embios/trunk/fat.c
——@@ -22,7 +22,6 @@
2323 #include "thread.h"
2424 #include <stdio.h>
2525 #include <string.h>
26 -#include <stdlib.h>
2726 #include <ctype.h>
2827 #include "fat.h"
2928 #include "storage.h"
Index: embios/trunk/dir.c
——@@ -22,7 +22,6 @@
2323 #include <stdio.h>
2424 #include <errno.h>
2525 #include <string.h>
26 -#include <stdlib.h>
2726 #include "fat.h"
2827 #include "dir.h"
2928 #include "debug.h"
Index: embios/trunk/file.h
——@@ -25,13 +25,12 @@
2626 #define MAX_PATH 260
2727
2828 #include "global.h"
29 -#include <sys/types.h>
3029 #include "thread.h"
3130 #include "gcc_extensions.h"
3231
33 -#ifndef MAX_OPEN_FILES
34 -#define MAX_OPEN_FILES 32
35 -#endif
 32+#ifndef MAX_OPEN_FILES
 33+#define MAX_OPEN_FILES 32
 34+#endif
3635
3736 #ifndef SEEK_SET
3837 #define SEEK_SET 0
Retrieved from "https://freemyipod.org/wiki/Special:Code/freemyipod/59"