freemyipod r357 - Code Review

Jump to: navigation, search

Repository:	freemyipod
Revision:	< r356‎ \| r357 \| r358 >
Date:	02:28, 20 December 2010
Author:	theseven
Status:	new
Tags:
Comment:	emBIOS: Fix a shutdown lockup
Modified paths:	/embios/trunk/target/ipodclassic/storage_ata.c (modified) (history)

Index: embios/trunk/target/ipodclassic/storage_ata.c
—	—	@@ -148,6 +148,7 @@
149	149	int ata_power_up()
150	150	{
151	151	ata_set_active();
	152	+ if (ata_powered) return 0;
152	153	i2c_sendbyte(0, 0xe6, 0x1b, 1);
153	154	clockgate_enable(5, true);
154	155	ATA_CFG = BIT(0);
—	—	@@ -239,6 +240,7 @@
240	241
241	242	void ata_power_down()
242	243	{
	244	+ if (!ata_powered) return;
243	245	ata_powered = false;
244	246	ata_wait_for_rdy(1000000);
245	247	ata_write_cbr(&ATA_PIO_DVR, 0);

Diff [purge]