freemyipod r686 - Code Review

Repository:	freemyipod
Revision:	< r685‎ \| r686 \| r687 >
Date:	23:46, 30 March 2011
Author:	theseven
Status:	new
Tags:
Comment:	libui: Fix chooser mutex not being unlocked before being destroyed
Modified paths:	/libs/ui/chooser.c (modified) (history)

Diff [purge]

Index: libs/ui/chooser.c
—	—	@@ -94,7 +94,6 @@
95	95	if (data.finished) goto finished;
96	96	redrawneeded \|= data.redrawneeded;
97	97	data.redrawneeded = false;
98		~~- mutex_unlock(&data.statemutex);~~
99	98	if ((long)(lasttick + info->tickinterval - USEC_TIMER) < 0)
100	99	{
101	100	if (info->actionhandler->handletick)
—	—	@@ -110,6 +109,7 @@
111	110	}
112	111	lasttick = USEC_TIMER;
113	112	}
	113	+ mutex_unlock(&data.statemutex);
114	114	if (redrawneeded) redrawneeded = info->renderer->render(&data) == CHOOSER_RESULT_REDRAW;
115	115	}
116	116	cancel:
—	—	@@ -116,6 +116,7 @@
117	117	data.selected = NULL;
118	118	finished:
119	119	rc = data.selected;
	120	+ mutex_unlock(&data.statemutex);
120	121	destroy_buttonhook:
121	122	button_unregister_handler(hook);
122	123	destroy_renderer: