freemyipod r931 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:< r930‎ | r931 | r932 >
Date:01:12, 6 June 2014
Author:theseven
Status:new
Tags:
Comment:
emCORE: Fix target-specific USB debugger requests being broken
Modified paths:
  • /emcore/trunk/target/ipodclassic/usbtarget.c (modified) (history)
  • /emcore/trunk/target/ipodnano2g/usbtarget.c (modified) (history)
  • /emcore/trunk/usb/usbdebug.c (modified) (history)

Diff [purge]

Index: emcore/trunk/target/ipodclassic/usbtarget.c
——@@ -71,9 +71,6 @@
7272 ata_bbt_disable();
7373 buf[0] = 1;
7474 break;
75 - default:
76 - buf[0] = 2;
77 - break;
7875 }
7976 return len;
8077 }
Index: emcore/trunk/target/ipodnano2g/usbtarget.c
——@@ -107,9 +107,6 @@
108108 buf[0] = 1;
109109 break;
110110 }
111 - default:
112 - buf[0] = 2;
113 - break;
114111 }
115112 return len;
116113 }
Index: emcore/trunk/usb/usbdebug.c
——@@ -694,13 +694,12 @@
695695 rtc_write_datetime((const struct rtc_datetime*)&buf[1]);
696696 break;
697697 #endif
 698+ default:
 699+ buf[0] = 2;
698700 #ifdef USB_HAVE_TARGET_SPECIFIC_REQUESTS
699 - if (buf[0] >= 0xffff0000)
700 - len = usb_target_handle_request(buf, sizeof(buf), &addr);
701 - break;
 701+ if (buf[0] >= 0xffff0000)
 702+ len = usb_target_handle_request(buf, sizeof(buf), &addr);
702703 #endif
703 - default:
704 - buf[0] = 2;
705704 break;
706705 }
707706 mode = enter_critical_section();
Retrieved from "https://freemyipod.org/wiki/Special:Code/freemyipod/931"