freemyipod r813 - Code Review

Repository:	freemyipod
Revision:	< r812‎ \| r813 \| r814 >
Date:	22:34, 22 November 2011
Author:	theseven
Status:	new
Tags:
Comment:	emCORE: Fix cache coherency bug in iPod Classic ATA driver
Modified paths:	/emcore/trunk/target/ipodclassic/storage_ata.c (modified) (history)

Diff [purge]

Index: emcore/trunk/target/ipodclassic/storage_ata.c
—	—	@@ -24,6 +24,7 @@
25	25	#include "storage.h"
26	26	#include "storage_ata-target.h"
27	27	#include "timer.h"
	28	+#include "malloc.h"
28	29	#include "constants/mmc.h"
29	30	#include "../ipodnano3g/s5l8702.h"
30	31
—	—	@@ -474,6 +475,7 @@
475	476	cmdtype = SDCI_CMD_CMD_TYPE_ADTC \| SDCI_CMD_CMD_RD_WR;
476	477	responsetype = SDCI_CMD_RES_TYPE_R1 \| SDCI_CMD_RES_BUSY;
477	478	direction = MMC_CMD_CEATA_RW_MULTIPLE_BLOCK_DIRECTION_WRITE;
	479	+ clean_dcache();
478	480	}
479	481	else
480	482	{
—	—	@@ -480,12 +482,12 @@
481	483	cmdtype = SDCI_CMD_CMD_TYPE_ADTC;
482	484	responsetype = SDCI_CMD_RES_TYPE_R1;
483	485	direction = MMC_CMD_CEATA_RW_MULTIPLE_BLOCK_DIRECTION_READ;
	486	+ invalidate_dcache();
484	487	}
485	488	SDCI_DMASIZE = 0x200;
486	489	SDCI_DMAADDR = buf;
487	490	SDCI_DMACOUNT = count;
488	491	SDCI_DCTRL = SDCI_DCTRL_TXFIFORST \| SDCI_DCTRL_RXFIFORST;
489		~~- invalidate_dcache();~~
490	492	PASS_RC(mmc_send_command(SDCI_CMD_CMD_NUM(MMC_CMD_CEATA_RW_MULTIPLE_BLOCK)
491	493	\| SDCI_CMD_CMD_TYPE_ADTC \| cmdtype \| responsetype
492	494	\| SDCI_CMD_RES_SIZE_48 \| SDCI_CMD_NCR_NID_NCR,
—	—	@@ -746,6 +748,7 @@
747	749	PASS_RC(ata_wait_for_start_of_transfer(500000), 2, 1);
748	750	if (write)
749	751	{
	752	+ clean_dcache();
750	753	ATA_SBUF_START = buffer;
751	754	ATA_SBUF_SIZE = SECTOR_SIZE * cnt;
752	755	ATA_CFG \|= BIT(4);
—	—	@@ -752,6 +755,7 @@
753	756	}
754	757	else
755	758	{
	759	+ invalidate_dcache();
756	760	ATA_TBUF_START = buffer;
757	761	ATA_TBUF_SIZE = SECTOR_SIZE * cnt;
758	762	ATA_CFG &= ~BIT(4);