freemyipod r23 - Code Review

Repository:	freemyipod
Revision:	< r22‎ \| r23 \| r24 >
Date:	03:20, 5 August 2010
Author:	farthen
Status:	new
Tags:
Comment:	Merge r18 and r19 into branches/4g_compat.
Modified paths:	/embios/branches/4g_compat (modified) (history) /embios/branches/4g_compat/Makefile (modified) (history) /embios/branches/4g_compat/strlen.c (modified) (history)

Diff [purge]

Index: embios/branches/4g_compat/strlen.c
—	—	@@ -22,15 +22,13 @@
23	23
24	24
25	25	#include "global.h"
26		~~-#include <string.h>~~
27		~~-#include <limits.h>~~
28	26
29		~~-size_t strlen(_CONST char *str)~~
	27	+
	28	+size_t strlen(const char *str)
30	29	{
31		~~- _CONST char *start = str;~~
	30	+ const char *start = str;
32	31
33		~~- while (*str)~~
34		~~- str++;~~
	32	+ while (*str) str++;
35	33
36	34	return str - start;
37	35	}
Index: embios/branches/4g_compat/Makefile
—	—	@@ -8,7 +8,7 @@
9	9	OBJCOPY := $(CROSS)objcopy
10	10	UCLPACK := ucl2e10singleblk
11	11
12		~~-CFLAGS ?= -Os -fno-pie -fno-stack-protector -fomit-frame-pointer -I. -ffunction-sections -fdata-sections -std=gnu99~~
	12	+CFLAGS ?= -Os -fno-pie -fno-stack-protector -fomit-frame-pointer -I. -ffunction-sections -fdata-sections
13	13	LDFLAGS ?= "$(shell $(CC) -print-libgcc-file-name)" --gc-sections
14	14
15	15	preprocess = $(shell $(CC) $(PPCFLAGS) $(2) -E -P -x c $(1) \| grep -v "^\#" \| sed -e "s:^..*:$(dir $(1))&:")
Index: embios/branches/4g_compat
Property changes on: embios/branches/4g_compat
___________________________________________________________________
Added: svn:mergeinfo
## -0,0 +0,1 ##
16	16	Merged /embios/trunk:r18-19

Revision	Commit summary	Author	Date
r18	Revert r12 and r13. They are unneccessary and might have nasty side effects.	theseven	23:04, 4 August 2010
r19	Simplify strlen.c	theseven	23:06, 4 August 2010