freemyipod r170 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:r169‎ | r170 | r171 >
Date:22:44, 21 August 2010
Author:theseven
Status:new
Tags:
Comment:
Fix a bunch of backlight-related bugs
Modified paths:
  • /apps/installer-nano2g/bootstub/bootstub.S (modified) (history)
  • /apps/installer-nano2g/flashfiles/iloader.cfg (modified) (history)
  • /apps/installer-nano2g/main.c (modified) (history)

Diff [purge]

Index: apps/installer-nano2g/flashfiles/iloader.cfg
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: apps/installer-nano2g/bootstub/bootstub.S
@@ -320,6 +320,18 @@
321321 orr r0, r0, #5
322322 orr r0, r0, #0x1000
323323 mcr p15, 0, r0,c1,c0 @ Re-enable the Protection Unit and caches
 324+ mov r0, #0xe6
 325+ mov r1, #0x2b
 326+ mov r2, #4
 327+ bl i2csendbyte
 328+ mov r0, #0xe6
 329+ mov r1, #0x28
 330+ mov r2, #10
 331+ bl i2csendbyte
 332+ mov r0, #0xe6
 333+ mov r1, #0x29
 334+ mov r2, #1
 335+ bl i2csendbyte
324336 ldr r1, _stubend + 4
325337 ldr r0, _stubend
326338 add r0, r1, r0
Index: apps/installer-nano2g/main.c
@@ -523,6 +523,9 @@
524524 ucl_decompress(bitmapdata[BMPIDX_WELCOME], bitmapsize[BMPIDX_WELCOME], bmpbuffer, &dummy);
525525 renderbmp(&lcdbuffer[176 * 25 + 25], bmpbuffer, 176);
526526 displaylcd(0, 175, 0, 131, lcdbuffer, 0);
 527+ backlight_set_fade(32);
 528+ backlight_set_brightness(177);
 529+ backlight_on(true);
527530 if (norword[0x400] == 0x53436667) appleflash = false;
528531 else if (norword[0x1000] == 0x53436667) appleflash = true;
529532 else panic(PANIC_KILLTHREAD, "Boot flash contents are damaged! "