freemyipod r915 - Code Review

Jump to: navigation, search
Repository:freemyipod
Revision:< r914‎ | r915 | r916 >
Date:16:20, 27 April 2014
Author:user890104
Status:new
Tags:
Comment:
emCOREFS: Fix gcc command-line issues, allows building with gcc 4.5+
Modified paths:
  • /emcore/trunk/tools/emcorefs/Makefile (modified) (history)
  • /emcore/trunk/tools/emcorefs/README (modified) (history)

Diff [purge]

Index: emcore/trunk/tools/emcorefs/Makefile
——@@ -1,5 +1,6 @@
22 GCC ?= gcc
3 -CFLAGS += -O2 -Wall -Wextra -Werror $(shell pkg-config --cflags --libs libusb-1.0 fuse)
 3+CFLAGS += -O2 -Wall -Wextra -Werror $(shell pkg-config --cflags libusb-1.0 fuse)
 4+LIBS = $(shell pkg-config --libs libusb-1.0 fuse)
45
56 SOURCES_COMMON = util.c usb.c emcore.c cache.c fuse.c
67 SOURCES_EMCOREFS = emcorefs.c
——@@ -13,15 +14,15 @@
1415
1516 $(TARGET_EMCOREFS): $(SOURCES_COMMON) $(SOURCES_EMCOREFS)
1617 @mkdir -p build
17 - $(GCC) $(CFLAGS) -o $(TARGET_EMCOREFS) $(SOURCES_COMMON) $(SOURCES_EMCOREFS)
 18+ $(GCC) $(CFLAGS) -o $(TARGET_EMCOREFS) $(SOURCES_COMMON) $(SOURCES_EMCOREFS) $(LIBS)
1819
1920 debug: $(SOURCES_COMMON) $(SOURCES_EMCOREFS)
2021 @mkdir -p build
21 - $(GCC) $(CFLAGS) -DDEBUG -g -o $(TARGET_EMCOREFS) $(SOURCES_COMMON) $(SOURCES_EMCOREFS)
 22+ $(GCC) $(CFLAGS) -DDEBUG -g -o $(TARGET_EMCOREFS) $(SOURCES_COMMON) $(SOURCES_EMCOREFS) $(LIBS)
2223
2324 $(TARGET_EMCORE_TEST): $(SOURCES_COMMON) $(SOURCES_EMCORE_TEST)
2425 @mkdir -p build
25 - $(GCC) $(CFLAGS) -DDEBUG -DDEBUG_USB_PACKETS -g -o $(TARGET_EMCORE_TEST) $(SOURCES_COMMON) $(SOURCES_EMCORE_TEST)
 26+ $(GCC) $(CFLAGS) -DDEBUG -DDEBUG_USB_PACKETS -g -o $(TARGET_EMCORE_TEST) $(SOURCES_COMMON) $(SOURCES_EMCORE_TEST) $(LIBS)
2627
2728 clean:
2829 @rm -rf build
Index: emcore/trunk/tools/emcorefs/README
——@@ -13,7 +13,7 @@
1414 Building
1515 --------
1616 You need:
17 -1. GCC 4.4 and GNU Make (Xcode on OS X)
 17+1. GCC and GNU Make (Xcode on OS X)
1818 2. pkg-config
1919 3. libusb >= 1.0
2020 4. libfuse >= 2.8 (or fuse4x on x64 OS X)
——@@ -20,7 +20,7 @@
2121 5. all dependencies of the above
2222
2323 Installing needed packages on Ubuntu
24 -sudo apt-get install gcc-4.4 make pkg-config libusb-1.0-0-dev libfuse-dev
 24+sudo apt-get install gcc make pkg-config libusb-1.0-0-dev libfuse-dev
2525
2626 Compiling:
2727 standard build, no debug messages, only fatal errors on startup are shown.
Retrieved from "https://freemyipod.org/wiki/Special:Code/freemyipod/915"