freemyipod r422 - Code Review

Repository:	freemyipod
Revision:	< r421‎ \| r422 \| r423 >
Date:	12:36, 15 January 2011
Author:	theseven
Status:	new
Tags:
Comment:	Fix shutdown logic: Should avoid both Ilitek LCD freezes and HDD emergency retracts
Modified paths:	/apps/uninstaller-classic/main.c (modified) (history) /apps/uninstaller-nano2g/main.c (modified) (history) /embios/trunk/shutdown.c (modified) (history)

Diff [purge]

Index: apps/uninstaller-classic/main.c
—	—	@@ -100,7 +100,6 @@
101	101	rendertext(&lcdbuffer[320 * 194 + 10], 0, 0xffff, "Will enter DFU mode in 5 seconds...", 320);
102	102	displaylcd(0, 319, 0, 239, lcdbuffer, 0);
103	103	sleep(5000000);
104		~~- backlight_on(false);~~
105	104	shutdown(true);
106	105	reset();
107	106	}
Index: apps/uninstaller-nano2g/main.c
—	—	@@ -227,6 +227,6 @@
228	228	rendertext(&lcdbuffer[177], 0, 0xffff, "Uninstallation successful! ", 176);
229	229	displaylcd(0, 175, 0, 131, lcdbuffer, 0);
230	230	sleep(1000000);
231		~~- shutdown(true);~~
	231	+ shutdown(false);
232	232	reset();
233	233	}
Index: embios/trunk/shutdown.c
—	—	@@ -33,6 +33,7 @@
34	34	#endif
35	35	#ifdef HAVE_STORAGE_FLUSH
36	36	storage_flush();
	37	+ storage_sleepnow();
37	38	#endif
38	39	if (shutdownhw)
39	40	{
—	—	@@ -43,9 +44,6 @@
44	45	#ifdef HAVE_LCD_SHUTDOWN
45	46	lcd_shutdown();
46	47	#endif
47		~~-#ifdef HAVE_STORAGE~~
48		~~- storage_sleepnow();~~
49		~~-#endif~~
50	48	}
51	49	#ifdef HAVE_LCD
52	50	else displaylcd_sync();